-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update debian packaging #752
base: main
Are you sure you want to change the base?
fix: update debian packaging #752
Conversation
diogomatsubara
commented
Oct 19, 2024
- include libzenohpico.so in debian package
- change the package name to libzenohpico in line with libzenohc
- set correct debian version for pre releases
- fix wrong version used in Release mode
PR missing one of the required labels: {'dependencies', 'documentation', 'breaking-change', 'new feature', 'internal', 'enhancement', 'bug'} |
set(project_version "${project_version}-dev") | ||
elseif(PROJECT_VERSION_TWEAK GREATER 1) | ||
set(debian_version "${project_version}~pre.${PROJECT_VERSION_TWEAK}-1") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not entirely clear for me what this -1
means and why it is hardcoded.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To comply with the debian version policy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can it be 2, 3 etc in future?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unlikely, so far we haven't had any reason to change it. In case we need to change in a further date I can make it default to -1
and allow the user to set a value.
- include libzenohpico.so in debian package - change the package name to libzenohpico in line with libzenohc - set correct debian version for pre releases - fix wrong version used in Release mode
fba07a9
to
2935b0d
Compare
I rebased on top of Denis's PR #751 which handles the |